cu_clean.c

Go to the documentation of this file.

/**********************************************************************
 *
 * PostGIS - Spatial Types for PostgreSQL
 * http://postgis.net
 *
 * Copyright (C) 2012 Sandro Santilli <strk@kbt.io>
 *
 * This is free software; you can redistribute and/or modify it under
 * the terms of the GNU General Public Licence. See the COPYING file.
 *
 **********************************************************************/

#include "CUnit/Basic.h"
#include "cu_tester.h"

#include "liblwgeom.h"
#include "liblwgeom_internal.h"
/*
 * TODO: change lwgeom_same to lwgeom_equals
 * (requires porting predicates to liblwgeom)
 */
#define check_geom_equal(gobt, gexp) do { \
        char *obt, *exp; \
        LWGEOM *ngobt, *ngexp; \
        ngobt = lwgeom_normalize(gobt); \
        ngexp = lwgeom_normalize(gexp); \
        if ( ! lwgeom_same((ngobt), (ngexp)) ) { \
                obt = lwgeom_to_wkt((ngobt), WKT_ISO, 8, NULL); \
                exp = lwgeom_to_wkt((ngexp), WKT_ISO, 8, NULL); \
                printf(" Failure at %s:%d\n", __FILE__, __LINE__); \
                printf(" Exp: %s\n", exp); \
                printf(" Obt: %s\n", obt); \
                free(obt); free(exp); \
    lwgeom_free(ngobt); lwgeom_free(ngexp); \
                CU_ASSERT(0); \
        } else { \
    lwgeom_free(ngobt); lwgeom_free(ngexp); \
    CU_ASSERT(1); \
  } \
} while (0)

static void test_lwgeom_make_valid(void)
{
        LWGEOM *gin, *gout, *gexp;
        char *ewkt;

        /* Because i don't trust that much prior tests...  ;) */
        cu_error_msg_reset();

        gin = lwgeom_from_wkt(
"MULTIPOLYGON(((1725063 4819121, 1725104 4819067, 1725060 4819087, 1725064.14183882 4819094.70208557,1725064.13656044 4819094.70235069,1725064.14210359 4819094.70227252,1725064.14210362 4819094.70227252,1725064.13656043 4819094.70235069,1725055. 4819094, 1725055 4819094, 1725055 4819094, 1725063 4819121)))",
                LW_PARSER_CHECK_NONE);
        CU_ASSERT(gin != NULL);

        gout = lwgeom_make_valid(gin);

        /* We're really only interested in avoiding a crash in here.
         * See http://trac.osgeo.org/postgis/ticket/1738
         * TODO: enhance the test if we find a workaround
         *       to the excepion:
         * See http://trac.osgeo.org/postgis/ticket/1735
         */

        lwgeom_free(gout);
        lwgeom_free(gin);

  /* Test for http://trac.osgeo.org/postgis/ticket/2307 */

  gin = lwgeom_from_hexwkb("0106000020E6100000010000000103000000010000000A0000004B7DA956B99844C0DB0790FE8B4D1DC010BA74A9AF9444C049AFFC5B8C4D1DC03FC6CC690D9844C0DD67E5628C4D1DC07117B56B0D9844C0C80ABA67C45E1DC0839166ABAF9444C0387D4568C45E1DC010BA74A9AF9444C049AFFC5B8C4D1DC040C3CD74169444C0362EC0608C4D1DC07C1A3B77169444C0DC3ADB40B2641DC03AAE5F68B99844C0242948DEB1641DC04B7DA956B99844C0DB0790FE8B4D1DC0", LW_PARSER_CHECK_NONE);
        CU_ASSERT(gin != NULL);

        gout = lwgeom_make_valid(gin);
        CU_ASSERT(gout != NULL);
        lwgeom_free(gin);

        /* We're really only interested in avoiding memory problems.
   * Convertion to ewkt ensures full scan of coordinates thus
   * triggering the error, if any
   */
        ewkt = lwgeom_to_ewkt(gout);
        lwgeom_free(gout);
        lwfree(ewkt);


        /* Test collection */

        gin = lwgeom_from_wkt(
"GEOMETRYCOLLECTION(LINESTRING(0 0, 0 0), POLYGON((0 0, 10 10, 10 0, 0 10, 0 0)), LINESTRING(10 0, 10 10))",
                LW_PARSER_CHECK_NONE);
        CU_ASSERT(gin != NULL);

        gout = lwgeom_make_valid(gin);
        CU_ASSERT(gout != NULL);

        ewkt = lwgeom_to_ewkt(gout);
        /* printf("c = %s\n", ewkt); */
        /*
         TODO: This doesn't work on windows returns in different order.
         strk figure out why. For now will replace with normalized version
        */
/*      CU_ASSERT_STRING_EQUAL(ewkt,
"GEOMETRYCOLLECTION(POINT(0 0),MULTIPOLYGON(((5 5,0 0,0 10,5 5)),((5 5,10 10,10 0,5 5))),LINESTRING(10 0,10 10))");*/
        gexp = lwgeom_from_wkt(
"GEOMETRYCOLLECTION(POINT(0 0),MULTIPOLYGON(((5 5,0 0,0 10,5 5)),((5 5,10 10,10 0,5 5))),LINESTRING(10 0,10 10))",
                LW_PARSER_CHECK_NONE);
        check_geom_equal(gout, gexp);
        lwfree(ewkt);

        lwgeom_free(gout);
        lwgeom_free(gin);
        lwgeom_free(gexp);

        /* Test multipoint */

        gin = lwgeom_from_wkt(
"MULTIPOINT(0 0,1 1,2 2)",
                LW_PARSER_CHECK_NONE);
        CU_ASSERT(gin != NULL);

        gout = lwgeom_make_valid(gin);
        CU_ASSERT(gout != NULL);

        ewkt = lwgeom_to_ewkt(gout);
        /* printf("c = %s\n", ewkt); */
        CU_ASSERT_STRING_EQUAL(ewkt,
"MULTIPOINT(0 0,1 1,2 2)");
        lwfree(ewkt);

        lwgeom_free(gout);
        lwgeom_free(gin);

        /* Test unclosed polygon */

        gin = lwgeom_from_hexwkb(
"0103000000010000000400000000000000000024400000000000003640000000000000244000000000000040400000000000003440000000000000404000000000000034400000000000003640",
                LW_PARSER_CHECK_NONE);
        CU_ASSERT(gin != NULL);

        gout = lwgeom_make_valid(gin);
        CU_ASSERT(gout != NULL);

        ewkt = lwgeom_to_ewkt(gout);
        /* printf("c = %s\n", ewkt); */
        CU_ASSERT_STRING_EQUAL(ewkt,
"POLYGON((10 22,10 32,20 32,20 22,10 22))");
        lwfree(ewkt);

        lwgeom_free(gout);
        lwgeom_free(gin);
}

/* TODO: add more tests ! */


/*
** Used by test harness to register the tests in this file.
*/
void clean_suite_setup(void);
void clean_suite_setup(void)
{
        CU_pSuite suite = CU_add_suite("geometry_clean", NULL, NULL);
        PG_ADD_TEST(suite, test_lwgeom_make_valid);
}